source: trunk/abcl/src/org/armedbear/lisp/SimpleError.java

Last change on this file was 15001, checked in by Mark Evenson, 7 years ago

Fix signalling simple error with #\~ in format string

(Alan Ruttenberg)

Signaling an simple error would signal another error if the message
happened to have a ~ in it, since in simple cases there are no format
args, but format is called with the message string.

We fix this by changing all cases in the source where there were calls
to setFormatControl(x) are followed by setFormatArguments(NIL). In
such cases we changed setFormatControl(x) ->
setFormatControl(x.replaceAll("~","")), which is the CL:FORMAT
recipe for escaping a #\~ character.

To replicate this error, place the following in a file
<file:~/work/abcl/double-error.lisp>.

(defun foo (x) (funcall x))

then

CL-USER> (compile-file "~/work/abcl/double-error")
; Compiling /Users/evenson/work/abcl/double-error.lisp ...
; (DEFUN FOO ...)
; Wrote /Users/evenson/work/abcl/double-error.abcl (0.015 seconds)
#P"/Users/evenson/work/abcl/double-error.abcl"
NIL
NIL
CL-USER> (foo '~)

gives

Error (FORMAT-ERROR) during printing: #<PROGRAM-ERROR {264F63C5}>

[Condition of type PROGRAM-ERROR]

Merges <https://github.com/armedbear/abcl/pull/41>.

  • Property svn:eol-style set to native
  • Property svn:keywords set to Id
File size: 2.7 KB
Line 
1/*
2 * SimpleError.java
3 *
4 * Copyright (C) 2003-2005 Peter Graves
5 * $Id: SimpleError.java 15001 2017-04-27 07:08:40Z mevenson $
6 *
7 * This program is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU General Public License
9 * as published by the Free Software Foundation; either version 2
10 * of the License, or (at your option) any later version.
11 *
12 * This program is distributed in the hope that it will be useful,
13 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
15 * GNU General Public License for more details.
16 *
17 * You should have received a copy of the GNU General Public License
18 * along with this program; if not, write to the Free Software
19 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
20 *
21 * As a special exception, the copyright holders of this library give you
22 * permission to link this library with independent modules to produce an
23 * executable, regardless of the license terms of these independent
24 * modules, and to copy and distribute the resulting executable under
25 * terms of your choice, provided that you also meet, for each linked
26 * independent module, the terms and conditions of the license of that
27 * module.  An independent module is a module which is not derived from
28 * or based on this library.  If you modify this library, you may extend
29 * this exception to your version of the library, but you are not
30 * obligated to do so.  If you do not wish to do so, delete this
31 * exception statement from your version.
32 */
33
34package org.armedbear.lisp;
35
36import static org.armedbear.lisp.Lisp.*;
37
38public final class SimpleError extends LispError
39{
40    public SimpleError(LispObject formatControl, LispObject formatArguments)
41
42    {
43        super(StandardClass.SIMPLE_ERROR);
44        setFormatControl(formatControl);
45        setFormatArguments(formatArguments);
46    }
47
48    public SimpleError(LispObject initArgs)
49    {
50        super(StandardClass.SIMPLE_ERROR);
51        initialize(initArgs);
52    }
53
54    public SimpleError(String message)
55    {
56        super(StandardClass.SIMPLE_ERROR);
57        setFormatControl(message.replaceAll("~","~~"));
58        setFormatArguments(NIL);
59    }
60
61    @Override
62    public LispObject typeOf()
63    {
64        return Symbol.SIMPLE_ERROR;
65    }
66
67    @Override
68    public LispObject classOf()
69    {
70        return StandardClass.SIMPLE_ERROR;
71    }
72
73    @Override
74    public LispObject typep(LispObject type)
75    {
76        if (type == Symbol.SIMPLE_ERROR)
77            return T;
78        if (type == StandardClass.SIMPLE_ERROR)
79            return T;
80        if (type == Symbol.SIMPLE_CONDITION)
81            return T;
82        if (type == StandardClass.SIMPLE_CONDITION)
83            return T;
84        return super.typep(type);
85    }
86}
Note: See TracBrowser for help on using the repository browser.