source: trunk/abcl/test/lisp/abcl/misc-tests.lisp

Last change on this file was 15652, checked in by Mark Evenson, 14 months ago

Avoid NIL in simple LOOP from FORMAT directives

(Tarn W. Burton) <https://github.com/yitzchak>

Simple LOOP requires only compound forms. Hence NIL is not
permitted. Some FORMAT directives (like newline) return NIL as the
form when they have nothing to add to the body. Normally this is fine
since BLOCK accepts NIL as a form. On the other hand, when the newline
directive is inside of an iteration directive this will produce
something like

(LOOP (fu) nil (bar))

This is probably mostly a spec compliance issue. It does not show up
as a bug since ABCL's Loop implementation isn't strict in this
sense. Loading an alternate LOOP implementation which is more strict
like Khazern will cause FORMAT to fail.

PRs have already been submitted and merged for some of the other
CMUCL-based FORMAT implementations like Clasp and ECL.

Via <https://github.com/armedbear/abcl/pull/559>.

  • Property svn:eol-style set to native
  • Property svn:keywords set to Id
File size: 5.0 KB
Line 
1;;; misc-tests.lisp
2;;;
3;;; Copyright (C) 2005 Peter Graves
4;;; $Id: misc-tests.lisp 15652 2023-02-22 07:59:00Z mevenson $
5;;;
6;;; This program is free software; you can redistribute it and/or
7;;; modify it under the terms of the GNU General Public License
8;;; as published by the Free Software Foundation; either version 2
9;;; of the License, or (at your option) any later version.
10;;;
11;;; This program is distributed in the hope that it will be useful,
12;;; but WITHOUT ANY WARRANTY; without even the implied warranty of
13;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
14;;; GNU General Public License for more details.
15;;;
16;;; You should have received a copy of the GNU General Public License
17;;; along with this program; if not, write to the Free Software
18;;; Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
19
20(in-package #:abcl.test.lisp)
21
22(deftest misc.dotimes.1
23  (progn
24    (fmakunbound 'misc.dotimes.1)
25    (defun misc.dotimes.1 ()
26      (let ((sum 0)) (dotimes (i 10) (setq i 42) (incf sum i)) sum))
27    (misc.dotimes.1))
28  420)
29
30(deftest dotimes.1.compiled
31  (progn
32    (fmakunbound 'dotimes.1.compiled)
33    (defun dotimes.1.compiled ()
34      (let ((sum 0)) (dotimes (i 10) (setq i 42) (incf sum i)) sum))
35    (compile 'dotimes.1.compiled)
36    (dotimes.1.compiled))
37  420)
38
39(deftest misc.dotimes.2
40  (progn
41    (fmakunbound 'misc.dotimes.2)
42    (defun misc.dotimes.2 (count)
43      (let ((sum 0)) (dotimes (i count) (setq i 42) (incf sum i)) sum))
44    (misc.dotimes.2 10))
45  420)
46
47(deftest dotimes.2.compiled
48  (progn
49    (fmakunbound 'dotimes.2.compiled)
50    (defun dotimes.2.compiled (count)
51      (let ((sum 0)) (dotimes (i count) (setq i 42) (incf sum i)) sum))
52    (compile 'dotimes.2.compiled)
53    (dotimes.2.compiled 10))
54  420)
55
56(deftest funcall.1
57  (funcall
58   (compile nil (lambda (a b c d e f) (list a b c d e f)))
59   1 2 3 4 5 6)
60  (1 2 3 4 5 6))
61
62(deftest funcall.2
63  (funcall
64   (compile nil (lambda (a b c d e f g) (list a b c d e f g )))
65   1 2 3 4 5 6 7)
66  (1 2 3 4 5 6 7))
67
68(deftest funcall.3
69  (funcall
70   (compile nil (lambda (a b c d e f g h) (list a b c d e f g h)))
71   1 2 3 4 5 6 7 8)
72  (1 2 3 4 5 6 7 8))
73
74(deftest funcall.4
75  (funcall
76   (compile nil (lambda (a b c d e f g h i) (list a b c d e f g h i)))
77   1 2 3 4 5 6 7 8 9)
78  (1 2 3 4 5 6 7 8 9))
79
80(deftest funcall.5
81  (funcall
82   (compile nil (lambda (a b c d e f g h i j) (list a b c d e f g h i j)))
83   1 2 3 4 5 6 7 8 9 10)
84  (1 2 3 4 5 6 7 8 9 10))
85
86(deftest copy-list.1
87  (eq (copy-list nil) nil)
88  t)
89
90(deftest read-from-string.1
91  (read-from-string "(1 2 #-abcl #k(3 4))")
92  (1 2)
93  20)
94
95(deftest read-from-string.2
96  (read-from-string "(1 2 #+nil #k(3 4))")
97  (1 2)
98  19)
99
100;; executed of the compiled expression below
101;; resulted in an error on pre-0.23 versions
102(defstruct mystruct slot)
103(deftest ticket.107
104    (funcall (compile nil
105                      '(lambda ()
106                         (let ((struct (make-mystruct))
107                               x)
108                           (setf (values (mystruct-slot struct)
109                                         x)
110                                 (values 42 2))))))
111  42 2)
112
113(deftest string-output-stream.seekable
114    (string= "Goodbye, World! Something."
115             (let ((stream (make-string-output-stream)))
116               (write-string "Hello, World!   Something." stream)
117               (file-position stream :start)
118               (write-string "Goodbye, World!" stream)
119               (get-output-stream-string stream)))
120  T)
121
122(deftest destructuring-bind.1
123  (signals-error (destructuring-bind (a b &rest c) '(1) (list a b)) 'program-error)
124  T)
125
126(deftest destructuring-bind.2
127  (signals-error (destructuring-bind (a . b) '() (list a b)) 'program-error)
128  T)
129
130(deftest destructuring-bind.3
131  (destructuring-bind (a . b) '(1) (list a b))
132  (1 NIL))
133
134;; this used to fail during byte code verification
135(deftest nth.inlined.1
136    (prog1 T (compile NIL (lambda (list) (nth (lambda ()) list))))
137  T)
138
139;; these used to fail during byte code verification
140(deftest throw.representation.1
141    (prog1 T (compile NIL (lambda () (eql (the fixnum (throw 'foo 42)) 2))))
142  T)
143
144(deftest throw.representation.2
145    (prog1 T (compile NIL (lambda () (char-code (the character (throw 'foo 42))))))
146  T)
147
148(deftest throw.representation.3
149    (prog1 T (compile NIL (lambda () (if (the boolean (throw 'foo 42)) 1 2))))
150  T)
151
152(deftest package-error-package.1
153    (package-error-package (nth-value 1 (ignore-errors (intern "FOO" :bar))))
154  :bar)
155
156;;; Simple LOOP requires only compound forms. Hence NIL is not
157;;; permitted. Some FORMAT directives (like newline) return NIL
158;;; as the form when they have nothing to add to the body.
159;;; Normally this is fine since BLOCK accepts NIL as a form. On
160;;; the other hand, when the newline directive is inside of an
161;;; iteration directive this will produce something like
162;;; (LOOP (fu) nil (bar)) which is not acceptable. To verify
163;;; that this is not happening we make sure we are not getting
164;;; (BLOCK NIL NIL) since this is easier to test for.
165(deftest format-no-nil-form.1
166    (third (second (macroexpand-1 '(formatter "~
167"))))
168  (block nil))
Note: See TracBrowser for help on using the repository browser.