Changeset 11816

Timestamp:

05/02/09 22:06:36 (14 years ago)

Author:

ehuelsmann

Message:

Selectively clear values in UNWIND-PROTECT:
don't clear if the protected form returns a single value.

File:

• trunk/abcl/src/org/armedbear/lisp/compiler-pass2.lisp (modified) (2 diffs)

trunk/abcl/src/org/armedbear/lisp/compiler-pass2.lisp

@@ -7875 +7875 @@
         (label BEGIN-PROTECTED-RANGE)
         (compile-form protected-form result-register nil)
-        (emit-push-current-thread)
-        (emit 'getfield +lisp-thread-class+ "_values" +lisp-object-array+)
-        (astore values-register)
+        (unless (single-valued-p protected-form)
+          (emit-push-current-thread)
+          (emit 'getfield +lisp-thread-class+ "_values" +lisp-object-array+)
+          (astore values-register))
         (label END-PROTECTED-RANGE))
       (dolist (subform cleanup-forms)
@@ -7887 +7888 @@
       (dolist (subform cleanup-forms)
         (compile-form subform nil nil))
-      (emit-clear-values)
+      (maybe-emit-clear-values cleanup-forms)
       (aload exception-register)
       (emit 'athrow) ; Re-throw exception.
       (label EXIT)
       ;; Restore multiple values returned by protected form.
-      (emit-push-current-thread)
-      (aload values-register)
-      (emit 'putfield +lisp-thread-class+ "_values" +lisp-object-array+)
+      (unless (single-valued-p protected-form)
+        (emit-push-current-thread)
+        (aload values-register)
+        (emit 'putfield +lisp-thread-class+ "_values" +lisp-object-array+))
       ;; Result.
       (aload result-register)