Changeset 11892

Timestamp:

05/17/09 14:38:44 (14 years ago)

Author:

ehuelsmann

Message:

Re-use fields of objects declared previously
within the same class file, instead of creating
separate fields for every reference.

Location:

trunk/abcl/src/org/armedbear/lisp

Files:

• compiler-pass2.lisp (modified) (1 diff)
• jvm.lisp (modified) (4 diffs)

trunk/abcl/src/org/armedbear/lisp/compiler-pass2.lisp

@@ -2198 +2198 @@
 
 The field type of the object is specified by OBJ-REF."
-  (let ((key (symbol-name (gensym "OBJ"))))
-    (remember key obj)
-    (let* ((g1 (declare-string key))
-           (g2 (symbol-name (gensym "O2BJ"))))
-      (let* ((*code* *static-code*))
-      (declare-field g2 obj-ref)
-      (emit 'getstatic *this-class* g1 +lisp-simple-string+)
-      (emit-invokestatic +lisp-class+ "recall"
-                         (list +lisp-simple-string+) +lisp-object+)
-      (when (and obj-class (string/= obj-class +lisp-object-class+))
-        (emit 'checkcast obj-class))
-      (emit 'putstatic *this-class* g2 obj-ref)
-      (setf *static-code* *code*)
-      g2))))
+  (let ((field-name (gethash1 obj *declared-objects*)))
+    (if field-name
+        field-name
+      (let ((key (symbol-name (gensym "OBJ"))))
+        (remember key obj)
+        (let* ((g1 (declare-string key))
+               (g2 (symbol-name (gensym "O2BJ")))
+               (*code* *static-code*))
+          (declare-field g2 obj-ref)
+          (emit 'getstatic *this-class* g1 +lisp-simple-string+)
+          (emit-invokestatic +lisp-class+ "recall"
+                             (list +lisp-simple-string+) +lisp-object+)
+          (when (and obj-class (string/= obj-class +lisp-object-class+))
+            (emit 'checkcast obj-class))
+          (emit 'putstatic *this-class* g2 obj-ref)
+          (setf *static-code* *code*)
+          (setf (gethash obj *declared-objects*) g2))))))
 
 (defun declare-lambda (obj)

trunk/abcl/src/org/armedbear/lisp/jvm.lisp

@@ -88 +88 @@
 (defvar *declared-floats* nil)
 (defvar *declared-doubles* nil)
+(defvar *declared-objects* nil)
 
 (defstruct (class-file (:constructor %make-class-file))
@@ -106 +107 @@
   (integers (make-hash-table :test 'eql))
   (floats (make-hash-table :test 'eql))
-  (doubles (make-hash-table :test 'eql)))
+  (doubles (make-hash-table :test 'eql))
+  (objects (make-hash-table :test 'eq)))
 
 (defun class-name-from-filespec (filespec)
@@ -138 +140 @@
             (*declared-integers*  (class-file-integers ,var))
             (*declared-floats*    (class-file-floats ,var))
-            (*declared-doubles*   (class-file-doubles ,var)))
+            (*declared-doubles*   (class-file-doubles ,var))
+            (*declared-objects*   (class-file-objects ,var)))
        (progn ,@body)
        (setf (class-file-pool ,var)         *pool*
@@ -150 +153 @@
              (class-file-integers ,var)     *declared-integers*
              (class-file-floats ,var)       *declared-floats*
-             (class-file-doubles ,var)      *declared-doubles*))))
+             (class-file-doubles ,var)      *declared-doubles*
+             (class-file-objects ,var)      *declared-objects*))))
 
 (defstruct compiland