Changeset 12394

Timestamp:

01/23/10 13:40:34 (12 years ago)

Author:

ehuelsmann

Message:

Remove premature optimization: new array creation is faster than

field access; at the same time, don't create too many new arrays.

File:

• trunk/abcl/src/org/armedbear/lisp/Closure.java (modified) (2 diffs)

trunk/abcl/src/org/armedbear/lisp/Closure.java

@@ -55 +55 @@
   private static final int STATE_AUX      = 4;
 
-  private static final Parameter[] emptyParameterArray;
-  static 
-    {
-        emptyParameterArray = new Parameter[0];
-    }
-  private Parameter[] requiredParameters = emptyParameterArray;
-  private Parameter[] optionalParameters = emptyParameterArray;
-  private Parameter[] keywordParameters = emptyParameterArray;
-  private Parameter[] auxVars = emptyParameterArray;
+  private Parameter[] requiredParameters = new Parameter[0];
+  private Parameter[] optionalParameters = requiredParameters;
+  private Parameter[] keywordParameters = requiredParameters;
+  private Parameter[] auxVars = requiredParameters;
   private final LispObject body;
   private final LispObject executionBody;
@@ -76 +71 @@
   private int maxArgs;
 
-  private static final Symbol[] emptySymbolArray;
-  static 
-    {
-        emptySymbolArray = new Symbol[0];
-    }
-  private Symbol[] variables = emptySymbolArray;
+  private Symbol[] variables = new Symbol[0];
   private LispObject specials = NIL;