Changeset 12426

Timestamp:

02/07/10 09:21:26 (11 years ago)

Author:

Mark Evenson

Message:

ABCL packed FASLS no longer have to end in ".abcl".

The requirement that packed FASLS had to end in ".abcl" was introduced
in the recent Pathname code as a optimization to avoid opening/closing
an input stream on the assumption that renaming FASLs would not be
expected to work. But COMPILE-FILE has an :OUTPUT-FILE arg that
certainly can be used, so we relax this restriction.

Found by dmiles in the ANSI test suite.

File:

• trunk/abcl/src/org/armedbear/lisp/Load.java (modified) (1 diff)

trunk/abcl/src/org/armedbear/lisp/Load.java

@@ -152 +152 @@
         }
 
-        if (truename.type.getStringValue().equals(COMPILE_FILE_TYPE)
-            && Utilities.checkZipFile(truename)) 
-            {
-                String n = truename.getNamestring();
-                if (n.startsWith("jar:")) {
-                    n = "jar:" + n + "!/" + truename.name.getStringValue() + "."
-                      + COMPILE_FILE_INIT_FASL_TYPE;
+        if (Utilities.checkZipFile(truename)) {
+            String n = truename.getNamestring();
+            if (n.startsWith("jar:")) {
+                n = "jar:" + n + "!/" + truename.name.getStringValue() + "."
+                    + COMPILE_FILE_INIT_FASL_TYPE;
+            } else {
+                n = "jar:file:" + n + "!/" + truename.name.getStringValue() + "."
+                    + COMPILE_FILE_INIT_FASL_TYPE;
+            }
+            mergedPathname = new Pathname(n);
+            LispObject initTruename = Pathname.truename(mergedPathname);
+            if (initTruename == null || initTruename.equals(NIL)) {
+                String errorMessage
+                    = "Loadable FASL not found for"
+                    + "'" + pathname + "'"
+                    + " in "
+                    + "'" + mergedPathname + "'";
+                if (ifDoesNotExist) {
+                    return error(new FileError(errorMessage, mergedPathname));
                 } else {
-                    n = "jar:file:" + n + "!/" + truename.name.getStringValue() + "."
-                      + COMPILE_FILE_INIT_FASL_TYPE;
-                }
-                mergedPathname = new Pathname(n);
-                LispObject initTruename = Pathname.truename(mergedPathname);
-                if (initTruename == null || initTruename.equals(NIL)) {
-                    String errorMessage
-                        = "Loadable FASL not found for"
-                          + "'" + pathname + "'"
-                          + " in "
-                          + "'" + mergedPathname + "'";
-                    if (ifDoesNotExist) {
-                        return error(new FileError(errorMessage, mergedPathname));
-                    } else {
-                        Debug.trace(errorMessage);
-                        return NIL;
-                    }
-                }
-                truename = (Pathname)initTruename;
-            }
+                    Debug.trace(errorMessage);
+                    return NIL;
+                }
+            }
+            truename = (Pathname)initTruename;
+        }
         
         InputStream in = truename.getInputStream();