Changeset 12590

Timestamp:

04/10/10 18:38:03 (13 years ago)

Author:

vvoutilainen

Message:

Make nthcdr and NTH(LispObject) final.

Location:

trunk/abcl/src/org/armedbear/lisp

Files:

• Cons.java (modified) (2 diffs)
• LispObject.java (modified) (2 diffs)
• Nil.java (modified) (2 diffs)

trunk/abcl/src/org/armedbear/lisp/Cons.java

@@ -135 +135 @@
 
   @Override
-  public LispObject nthcdr(int n)
-  {
-    if (n < 0)
-      return type_error(Fixnum.getInstance(n),
-                             list(Symbol.INTEGER, Fixnum.ZERO));
-    LispObject result = this;
-    for (int i = n; i-- > 0;)
-      {
-        result = result.cdr();
-        if (result == NIL)
-          break;
-      }
-    return result;
-  }
-
-  @Override
   public final int sxhash()
   {
@@ -247 +231 @@
     if (index < 0)
       type_error(Fixnum.getInstance(index), Symbol.UNSIGNED_BYTE);
-    int i = 0;
-    LispObject obj = this;
-    while (true)
-      {
-        if (i == index)
-          return obj.car();
-        obj = obj.cdr();
-        if (obj == NIL)
-          return NIL;
-        ++i;
-      }
-  }
-
-  @Override
-  public LispObject NTH(LispObject arg)
-  {
-    int index;
-    if (arg instanceof Fixnum)
-      {
-        index = ((Fixnum)arg).value;
-      }
-    else
-        {
-        if (arg instanceof Bignum)
-          {
-            // FIXME (when machines have enough memory for it to matter)
-            if (arg.minusp())
-              return type_error(arg, Symbol.UNSIGNED_BYTE);
-            return NIL;
-          }
-        return type_error(arg, Symbol.UNSIGNED_BYTE);
-      }
-    if (index < 0)
-      type_error(arg, Symbol.UNSIGNED_BYTE);
     int i = 0;
     LispObject obj = this;

trunk/abcl/src/org/armedbear/lisp/LispObject.java

@@ -223 +223 @@
   }
 
-  public LispObject nthcdr(int n)
+  public final LispObject nthcdr(int n)
   {
     if (n < 0)
       return type_error(Fixnum.getInstance(n),
                              list(Symbol.INTEGER, Fixnum.ZERO));
+    if (this instanceof Cons) {
+      LispObject result = this;
+      for (int i = n; i-- > 0;) {
+          result = result.cdr();
+          if (result == NIL)
+              break;
+      }
+      return result;
+    } else if (this instanceof Nil) {
+      return NIL;
+    }
     return type_error(this, Symbol.LIST);
   }
@@ -483 +494 @@
   }
 
-  public LispObject NTH(LispObject arg)
-  {
-    return type_error(this, Symbol.LIST);
+  public final LispObject NTH(LispObject arg)
+  {
+    return NTH(Fixnum.getValue(arg));
   }
 

trunk/abcl/src/org/armedbear/lisp/Nil.java

@@ -108 +108 @@
 
     @Override
-    public LispObject nthcdr(int n)
-    {
-        if (n < 0)
-            return type_error(Fixnum.getInstance(n),
-                                   list(Symbol.INTEGER, Fixnum.ZERO));
-        return this;
-    }
-
-    @Override
     public int length()
     {
@@ -129 +120 @@
                                  " is not of type UNSIGNED-BYTE."));
         return NIL;
-    }
-
-    @Override
-    public LispObject NTH(LispObject arg)
-    {
-        int index;
-                if (arg instanceof Fixnum) {
-                        index = ((Fixnum) arg).value;
-                } else if (arg instanceof Bignum) {
-                        if (arg.minusp())
-                                return error(new TypeError(arg, Symbol.UNSIGNED_BYTE));
-                        return NIL;
-                } else
-                        return error(new TypeError(arg, Symbol.UNSIGNED_BYTE));
-                if (index < 0)
-                        error(new TypeError(arg, Symbol.UNSIGNED_BYTE));
-                return NIL;
     }