Changeset 12711

Timestamp:

05/19/10 22:29:03 (13 years ago)

Author:

ehuelsmann

Message:

No longer use the reader to load "stand alone" uninterned symbols,
instead, inline calls to the array element 'getter'.

Location:

trunk/abcl/src/org/armedbear/lisp

Files:

• compiler-pass2.lisp (modified) (2 diffs)
• dump-form.lisp (modified) (3 diffs)

trunk/abcl/src/org/armedbear/lisp/compiler-pass2.lisp

@@ -214 +214 @@
 (defconstant +lisp-thread-class+ "org/armedbear/lisp/LispThread")
 (defconstant +lisp-thread+ "Lorg/armedbear/lisp/LispThread;")
+(defconstant +lisp-load-class+ "org/armedbear/lisp/Load")
 (defconstant +lisp-cons-class+ "org/armedbear/lisp/Cons")
 (defconstant +lisp-cons+ "Lorg/armedbear/lisp/Cons;")
@@ -2151 +2152 @@
        (emit 'getstatic class name +lisp-symbol+))
       ((null (symbol-package symbol))
-       ;; we need to read the #?<n> syntax for uninterned symbols
-
-       ;; TODO: we could use the byte code variant of
-       ;; Load._FASL_UNINTERNED_SYMBOLS_.symbolValue(LispThread.currentThread())
-       ;;    .aref(<index)
-       ;; to eliminate the reader dependency
-       (serialize-object symbol)
+       (emit-push-constant-int (dump-uninterned-symbol-index symbol))
+       (emit-invokestatic +lisp-load-class+ "getUninternedSymbol" '("I")
+                          +lisp-object+)
        (emit 'checkcast +lisp-symbol-class+))
       ((keywordp symbol)

trunk/abcl/src/org/armedbear/lisp/dump-form.lisp

@@ -32 +32 @@
 (in-package "SYSTEM")
 
-(export 'dump-form)
+(export '(dump-form dump-uninterned-symbol-index))
 
 (declaim (ftype (function (cons stream) t) dump-cons))
@@ -90 +90 @@
         (dump-object creation-form stream))))
 
+(declaim (ftype (function (symbol) integer) dump-uninterned-symbol-index))
+(defun dump-uninterned-symbol-index (symbol)
+  (let ((index (cdr (assoc symbol *fasl-uninterned-symbols*))))
+    (unless index
+      (setq index (1+ (or (cdar *fasl-uninterned-symbols*) -1)))
+      (setq *fasl-uninterned-symbols*
+            (acons symbol index *fasl-uninterned-symbols*)))
+    index))
+
 (declaim (ftype (function (t stream) t) dump-object))
 (defun dump-object (object stream)
@@ -106 +115 @@
         ((and (symbolp object) ;; uninterned symbol
               (null (symbol-package object)))
-         (let ((index (cdr (assoc object *fasl-uninterned-symbols*))))
-           (unless index
-             (setq index (1+ (or (cdar *fasl-uninterned-symbols*) -1)))
-             (setq *fasl-uninterned-symbols*
-                   (acons object index *fasl-uninterned-symbols*)))
-           (write-string "#" stream)
-           (write index :stream stream)
-           (write-string "?" stream)))
+         (write-string "#" stream)
+         (write (dump-uninterned-symbol-index object) :stream stream)
+         (write-string "?" stream))
         (t
          (%stream-output-object object stream))))