Changeset 12781 for branches/generic-class-file/abcl/src/org/armedbear/lisp/jvm-class-file.lisp

Timestamp:

07/04/10 07:49:14 (13 years ago)

Author:

ehuelsmann

Message:

Small fixes found by test-writing.

File:

• branches/generic-class-file/abcl/src/org/armedbear/lisp/jvm-class-file.lisp (modified) (4 diffs)

branches/generic-class-file/abcl/src/org/armedbear/lisp/jvm-class-file.lisp

@@ -154 +154 @@
 
 (defun internal-field-type (field-type)
-  (if (keywordp field-type)
+  (if (symbolp field-type)
       (map-primitive-type field-type)
       (class-name-internal field-type)))
 
 (defun internal-field-ref (field-type)
-  (if (keywordp field-type)
+  (if (symbolp field-type)
       (map-primitive-type field-type)
       (class-ref field-type)))
 
 (defun descriptor (return-type &rest argument-types)
-  (format nil "(~{~A~}~A)" (mapcar #'internal-field-ref argument-types)
+  (format nil "(~{~A~})~A" (mapcar #'internal-field-ref argument-types)
           (internal-field-type return-type)))
 
@@ -402 +402 @@
 
 (defun class-add-attribute (class attribute)
-  (push atttribute (class-file-attributes class)))
+  (push attribute (class-file-attributes class)))
 
 (defun class-attribute (class name)
@@ -416 +416 @@
   (setf (class-file-access-flags class)
         (map-flags (class-file-access-flags class)))
-  (setf (class-file-class-name class)
-        (pool-add-class (class-name-internal (class-file-class-name class))))
+  (setf (class-file-class class)
+        (pool-add-class (class-name-internal (class-file-class class))))
   ;;  (finalize-interfaces)
   (dolist (field (class-file-fields class))
@@ -583 +583 @@
   "Creates an (empty) 'Code' attribute for the method."
   (method-add-attribute
-   (make-code-attribute (+ (length args)
+   (make-code-attribute (+ (length (cdr (method-descriptor method)))
                            (if (member :static (method-access-flags method))
                                0 1))))) ;; 1 == implicit 'this'