Changeset 13369

Timestamp:

07/01/11 14:00:27 (12 years ago)

Author:

Mark Evenson

Message:

Make JAVA:ADD-TO-CLASSPATH a generic function.

With this change we can customize the mechanism for changing the
classpath. The first planned use is for JSS to use an :after method
to be informed of classpath additions, so we can factor out the ASDF
portion into the ABCL-ASDF extension package.

Add JAVA:GET-CURRENT-CLASSLOADER to access a wrapped instance of the
underlying current JVM classloader being used by ABCL.

Location:

trunk/abcl/src/org/armedbear/lisp

Files:

• Autoload.java (modified) (1 diff)
• JavaClassLoader.java (modified) (2 diffs)
• Symbol.java (modified) (2 diffs)
• java.lisp (modified) (1 diff)

trunk/abcl/src/org/armedbear/lisp/Autoload.java

@@ -533 +533 @@
         autoload(PACKAGE_JAVA, "get-default-classloader", "JavaClassLoader");
         autoload(PACKAGE_JAVA, "make-classloader", "JavaClassLoader");
-        autoload(PACKAGE_JAVA, "add-to-classpath", "JavaClassLoader");
+        autoload(PACKAGE_JAVA, "%add-to-classpath", "JavaClassLoader");
         autoload(PACKAGE_JAVA, "dump-classpath", "JavaClassLoader");
         autoload(PACKAGE_MOP, "funcallable-instance-function", "StandardGenericFunction", false);

trunk/abcl/src/org/armedbear/lisp/JavaClassLoader.java

@@ -198 +198 @@
     };
 
-    // ### add-to-classpath jar-or-jars &optional (classloader (get-current-classloader))
+    private static final Primitive GET_CURRENT_CLASSLOADER = new pf_get_current_classloader();
+    @DocString(name="get-current-classloader")
+    private static final class pf_get_current_classloader extends Primitive {
+        pf_get_current_classloader() {
+            super("get-current-classloader", PACKAGE_JAVA, true);
+        }
+        @Override 
+        public LispObject execute() {
+            return new JavaObject(getCurrentClassLoader());
+        }
+    };
+        
+    // ### %add-to-classpath jar-or-jars &optional (classloader (get-current-classloader))
     private static final Primitive ADD_TO_CLASSPATH = new pf_add_to_classpath();
     private static final class pf_add_to_classpath extends Primitive 
@@ -204 +216 @@
         pf_add_to_classpath() 
         {
-            super("add-to-classpath", PACKAGE_JAVA, true, "jar-or-jars &optional (classloader (get-current-classloader))");
+            super("%add-to-classpath", PACKAGE_JAVA, false, 
+                  "jar-or-jars &optional (classloader (get-current-classloader))");
         }
 

trunk/abcl/src/org/armedbear/lisp/Symbol.java

@@ -2977 +2977 @@
     PACKAGE_JAVA.addExternalSymbol("JAVA-OBJECT");
   public static final Symbol JAVA_CLASS =
-      PACKAGE_JAVA.addExternalSymbol("JAVA-CLASS");
+    PACKAGE_JAVA.addExternalSymbol("JAVA-CLASS");
   public static final Symbol JCALL =
     PACKAGE_JAVA.addExternalSymbol("JCALL");
@@ -2992 +2992 @@
   public static final Symbol JRESOLVE_METHOD =
     PACKAGE_JAVA.addExternalSymbol("JRESOLVE-METHOD");
+  public static final Symbol ADD_TO_CLASSPATH =
+    PACKAGE_JAVA.addExternalSymbol("ADD-TO-CLASSPATH");
 
   // External symbols in SYSTEM package.

trunk/abcl/src/org/armedbear/lisp/java.lisp

@@ -43 +43 @@
   (dolist (url urls)
     (add-url-to-classpath url)))
+
+(defgeneric add-to-classpath (jar-or-jars &optional classloader))
+
+(defmethod add-to-classpath (jar-or-jars &optional (classloader (get-current-classloader)))
+  (%add-to-classpath jar-or-jars classloader))
 
 (defun jregister-handler (object event handler &key data count)