Changeset 13380

Timestamp:

07/08/11 08:40:37 (10 years ago)

Author:

Mark Evenson

Message:

Fasls are no no longer created with *PRINT-READABLY*.

This fixes #156 in which the compiler could no longer dump forms into
the fasls containing arrays of (UNSIGNED-BYTE 32) because in r13274 we
required that all forms be created with a non-nil *PRINT-READABLY*.
Presumably, SimpleArray_UnsignedByte32.writeToString() signals an
error when invoked with a non-NIL *PRINT-READABLY* because the
resulting read of the form will not necessarily be of the specified
base type.

With this change, we restore ABCL's behavior before r13274 to fix
#147, which is to read a create a less precise type from the fasl.

The more correct solution would be to dump some aspects of the fasls
directly into JVM code that would perform the stricter intialization.

Tests added for both cases to ensure this remains fixed.

Location:

trunk/abcl

Files:

• src/org/armedbear/lisp/dump-form.lisp (modified) (1 diff)
• test/lisp/abcl/compiler-tests.lisp (modified) (1 diff)

trunk/abcl/src/org/armedbear/lisp/dump-form.lisp

@@ -135 +135 @@
         (*print-pretty* nil)
         (*print-radix* nil)
+#+nil ;; XXX Some types (q.v. (UNSIGNED-BYTE 32)) don't have a
+      ;; readable syntax because they don't roundtrip to the same
+      ;; type, but still return a Lisp object that "works", albeit
+      ;; perhaps inefficiently when READ from their DUMP-FORM
+      ;; representation.
         (*print-readably* t)
         (*print-right-margin* nil)

trunk/abcl/test/lisp/abcl/compiler-tests.lisp

@@ -444 +444 @@
   :results #.most-positive-java-long)
 
+;;; ticket #147
+(deftest compiler.1 
+    (let ((tmpfile (ext::make-temp-file))
+          (forms `((in-package :cl-user)
+                     (eval-when (:compile-toplevel :load-toplevel :execute)
+                       (setf *print-case* ':downcase))
+                     (defstruct rec a b))))
+      (with-open-file (s tmpfile :direction :output)
+        (dolist (form forms)
+          (write form :stream s)))
+      (let ((result (compile-file tmpfile)))
+        (delete-file tmpfile)
+        (not (null result))))
+  t)
+
+;;; ticket #156
+(deftest compiler.2
+    (let ((tmpfile (ext::make-temp-file))
+          (line "(defconstant a #.(make-array '(8 256) 
+                    :element-type '(unsigned-byte 32) :initial-element 0))"))
+      (with-open-file (s tmpfile :direction :output)
+        (format s "~A" line))
+      (let ((result (compile-file tmpfile)))
+    #+nil    (delete-file tmpfile)
+        (not (null result))))
+  t)
+
+
+
+
+
+        
+
+        
+