Changeset 13530

Timestamp:

08/22/11 09:52:28 (10 years ago)

Author:

Mark Evenson

Message:

All LispThread? objects can act on a ProcessingTerminated? exception.

Without this modifications, threads created with the
THREADS:MAKE-THREADS cannot successfully call the EXT:QUIT or EXT:EXIT
functions. This prevented the SLIME quit implementation from
successfully quitting implementations.

Note that all threads can always execute a form like

(jstatic "exit" "java.lang.System" 0)

to uncermoniously exit the JVM, so there is nothing gained
security-wise by preventing threads from using the official Lisp
interfaces.

File:

• trunk/abcl/src/org/armedbear/lisp/LispThread.java (modified) (2 diffs)

trunk/abcl/src/org/armedbear/lisp/LispThread.java

@@ -42 +42 @@
 import java.util.concurrent.atomic.AtomicInteger;
 
+import java.text.MessageFormat;
+
 public final class LispThread extends LispObject
 {
@@ -99 +101 @@
                       // Might happen.
                 }
+                catch (ProcessingTerminated e) {
+                    System.exit(e.getStatus());
+                }
                 catch (Throwable t) { // any error: process thread interrupts
                     if (isInterrupted()) {
                         processThreadInterrupts();
                     }
+                    String msg 
+                        = MessageFormat.format("Ignoring uncaught exception {0}.",
+                                               t.toString());
+                    Debug.warn(msg);
                 }
                 finally {