Changeset 13787

Timestamp:

01/17/12 19:39:54 (11 years ago)

Author:

ehuelsmann

Message:

Implement keyword argument verification in the method invocation protocol.

File:

• trunk/abcl/src/org/armedbear/lisp/clos.lisp (modified) (5 diffs)

trunk/abcl/src/org/armedbear/lisp/clos.lisp

@@ -2028 +2028 @@
       (return (values nil t)))))))
 
+(defun check-applicable-method-keyword-args (gf args
+                                             keyword-args
+                                             applicable-keywords)
+  (when (oddp (length keyword-args))
+    (error 'program-error
+           :format-control "Odd number of keyword arguments in call to ~S ~
+with arguments list ~S"
+           :format-arguments (list gf args)))
+  (unless (getf keyword-args :allow-other-keys)
+    (loop for key in keyword-args by #'cddr
+       unless (or (member key applicable-keywords)
+                  (eq key :allow-other-keys))
+       do (error 'program-error
+                 :format-control "Invalid keyword argument ~S in call ~
+to ~S with argument list ~S."
+                 :format-arguments (list key gf args)))))
+
+(defun compute-applicable-keywords (gf applicable-methods)
+  (let ((applicable-keywords
+         (getf (analyze-lambda-list (generic-function-lambda-list gf))
+               :keywords)))
+    (loop for method in applicable-methods
+       do (multiple-value-bind
+                (keywords allow-other-keys)
+              (function-keywords method)
+            (when allow-other-keys
+              (setf applicable-keywords :any)
+              (return))
+            (setf applicable-keywords
+                  (union applicable-keywords keywords))))
+    applicable-keywords))
+
+(defun wrap-emfun-for-keyword-args-check (gf emfun non-keyword-args
+                                          applicable-keywords)
+  #'(lambda (args)
+      (check-applicable-method-keyword-args
+         gf args
+         (nthcdr non-keyword-args args) applicable-keywords)
+      (funcall emfun args)))
+
 (defun slow-method-lookup (gf args)
   (let ((applicable-methods (%compute-applicable-methods gf args)))
     (if applicable-methods
-        (let ((emfun (funcall (if (eq (class-of gf) +the-standard-generic-function-class+)
-                                  #'std-compute-effective-method-function
-                                  #'compute-effective-method-function)
-                              gf applicable-methods)))
+        (let* ((emfun (funcall (if (eq (class-of gf) +the-standard-generic-function-class+)
+                                   #'std-compute-effective-method-function
+                                   #'compute-effective-method-function)
+                               gf applicable-methods))
+               (non-keyword-args
+                (+ (length (gf-required-args gf))
+                   (length (gf-optional-args gf))))
+               (gf-lambda-list (generic-function-lambda-list gf))
+               (checks-required (and (member '&key gf-lambda-list)
+                                     (not (member '&allow-other-keys
+                                                  gf-lambda-list)))
+                 )
+              (applicable-keywords
+               (when checks-required
+                 ;; Don't do applicable keyword checks when this is
+                 ;; one of the 'exceptional four' or when the gf allows
+                 ;; other keywords.
+                 (compute-applicable-keywords gf applicable-methods))))
+          (when (and checks-required
+                     (not (eq applicable-keywords :any)))
+            (setf emfun
+                  (wrap-emfun-for-keyword-args-check gf emfun non-keyword-args
+                                                     applicable-keywords)))
           (cache-emf gf args emfun)
           (funcall emfun args))
@@ -2408 +2467 @@
     (%set-method-fast-function method fast-function)
     (set-reader-method-slot-name method slot-name)
+    (%set-function-keywords method nil nil)
     method))
 
@@ -2831 +2891 @@
               (unless (memq initarg allowable-initargs)
                 (error 'program-error
-                       :format-control "Invalid initarg ~S in call to ~S ~
-with arglist ~S."
+                       :format-control "Invalid initarg ~S in call to ~S with arglist ~S."
                        :format-arguments (list initarg call-site args))))))))
 
@@ -2950 +3009 @@
                                         &key &allow-other-keys))
 
-(defmethod shared-initialize ((instance standard-object) slot-names &rest initargs)
+(defmethod shared-initialize ((instance standard-object) slot-names
+                              &rest initargs)
   (std-shared-initialize instance slot-names initargs))
 
@@ -3373 +3433 @@
     (%function-keywords method)))
 
-
 (setf *gf-initialize-instance* (symbol-function 'initialize-instance))
 (setf *gf-allocate-instance* (symbol-function 'allocate-instance))