Changeset 13792

Timestamp:

01/20/12 01:10:39 (9 years ago)

Author:

astalla

Message:

A small reorganization of compiler/jvm code. Runtime-class wasn't autoloading properly in certain situations due to a wrong dependency graph among some system files.

Location:

trunk/abcl/src/org/armedbear/lisp

Files:

• compiler-pass2.lisp (modified) (1 diff)
• jvm-class-file.lisp (modified) (2 diffs)
• jvm-instructions.lisp (modified) (1 diff)
• jvm.lisp (modified) (1 diff)
• known-symbols.lisp (modified) (1 diff)
• runtime-class.lisp (modified) (3 diffs)

trunk/abcl/src/org/armedbear/lisp/compiler-pass2.lisp

@@ -43 +43 @@
   (require "DUMP-FORM")
   (require "JVM-INSTRUCTIONS")
+  (require "JVM-CLASS-FILE")
   (require "JAVA"))
 

trunk/abcl/src/org/armedbear/lisp/jvm-class-file.lisp

@@ -31 +31 @@
 
 (in-package "JVM")
+(require '#:compiler-types)
 
 #|
@@ -1512 +1513 @@
 |#
 
+(provide '#:jvm-class-file)

trunk/abcl/src/org/armedbear/lisp/jvm-instructions.lisp

@@ -33 +33 @@
 (in-package #:jvm)
 
+(declaim (inline u2 s1 s2))
+
+(defknown u2 (fixnum) cons)
+(defun u2 (n)
+  (declare (optimize speed))
+  (declare (type (unsigned-byte 16) n))
+  (when (not (<= 0 n 65535))
+    (error "u2 argument ~A out of 65k range." n))
+  (list (logand (ash n -8) #xff)
+        (logand n #xff)))
+
+(defknown s1 (fixnum) fixnum)
+(defun s1 (n)
+  (declare (optimize speed))
+  (declare (type (signed-byte 8) n))
+  (when (not (<= -128 n 127))
+    (error "s1 argument ~A out of 8-bit signed range." n))
+  (if (< n 0)
+      (1+ (logxor (- n) #xFF))
+      n))
+
+
+(defknown s2 (fixnum) cons)
+(defun s2 (n)
+  (declare (optimize speed))
+  (declare (type (signed-byte 16) n))
+  (when (not (<= -32768 n 32767))
+    (error "s2 argument ~A out of 16-bit signed range." n))
+  (u2 (if (< n 0) (1+ (logxor (- n) #xFFFF))
+          n)))
 
 ;;    OPCODES

trunk/abcl/src/org/armedbear/lisp/jvm.lisp

@@ -71 +71 @@
   (declare (ignore ignored)))
 
-(declaim (inline u2 s1 s2))
-
-(defknown u2 (fixnum) cons)
-(defun u2 (n)
-  (declare (optimize speed))
-  (declare (type (unsigned-byte 16) n))
-  (when (not (<= 0 n 65535))
-    (error "u2 argument ~A out of 65k range." n))
-  (list (logand (ash n -8) #xff)
-        (logand n #xff)))
-
-(defknown s1 (fixnum) fixnum)
-(defun s1 (n)
-  (declare (optimize speed))
-  (declare (type (signed-byte 8) n))
-  (when (not (<= -128 n 127))
-    (error "s1 argument ~A out of 8-bit signed range." n))
-  (if (< n 0)
-      (1+ (logxor (- n) #xFF))
-      n))
-
-
-(defknown s2 (fixnum) cons)
-(defun s2 (n)
-  (declare (optimize speed))
-  (declare (type (signed-byte 16) n))
-  (when (not (<= -32768 n 32767))
-    (error "s2 argument ~A out of 16-bit signed range." n))
-  (u2 (if (< n 0) (1+ (logxor (- n) #xFFFF))
-          n)))
-
-
-
-
-
 (defmacro with-saved-compiler-policy (&body body)
   "Saves compiler policy variables, restoring them after evaluating `body'."

trunk/abcl/src/org/armedbear/lisp/known-symbols.lisp

@@ -32 +32 @@
 (in-package #:system)
 
+(require "JVM-CLASS-FILE")
 (require "JAVA")
 

trunk/abcl/src/org/armedbear/lisp/runtime-class.lisp

@@ -1 @@
-(require "COMPILER-PASS2")
-(require "JVM-CLASS-FILE")
+(require "JVM")
 
 ;;The package is set to :jvm for convenience, since most of the symbols used
@@ -187 +186 @@
               (cond
                 ((jvm-class-name-p type) (aload 1))
-                ((eq type :int) (iload 1))
+                ((eq type :int) (emit 'iload 1))
                 (t (error "Unsupported setter parameter type: ~A" type)))
               (emit-putfield (class-file-class class-file) name type)
@@ -219 +218 @@
 
 ;;TODO:
+;; - Returning nil as null is broken
 ;; - Function calls with 8+ args
 ;; - super method invocation. Idea: generate companion methods super_... to use with plain jcall. Add a flag per method to optionally disable this when not needed.