Changeset 13807

Timestamp:

01/25/12 13:34:03 (11 years ago)

Author:

Mark Evenson

Message:

Further fix for ABCL-ASDF load time failure.

Start separating out the public api by exporting and documenting symbols.

Location:

trunk/abcl/contrib/abcl-asdf

Files:

• abcl-asdf.asd (modified) (2 diffs)
• maven-embedder.lisp (modified) (5 diffs)
• packages.lisp (modified) (2 diffs)

trunk/abcl/contrib/abcl-asdf/abcl-asdf.asd

@@ -21 +21 @@
 (defsystem :abcl-asdf-test
   :author "Mark Evenson"
-  :depends-on (abcl abcl-test-lisp)
+  :depends-on (abcl)
   :components
   ((:module tests :components
@@ -27 +27 @@
                    (:file "maven")))))
 
+#+nil FIXME
 (defmethod perform ((o test-op) (c (eql (find-system 'abcl-asdf))))
    "Invoke tests with (asdf:test-system 'abcl-asdf)."
+   (asdf:load-system 'abcl)
+   (asdf:load-system 'abcl-test-lisp)
    (asdf:load-system 'abcl-asdf-test)
    (funcall (intern (symbol-name 'run) 'abcl-asdf-test)))

trunk/abcl/contrib/abcl-asdf/maven-embedder.lisp

@@ -14 +14 @@
 (resolve-dependencies "org.slf4j" "slf4j-api" "1.6.1")
 
-(resolve-dependencies "org.apache.maven" "maven-aether-provider" "3.0.3")
+(resolve-dependencies "org.apache.maven" "maven-aether-provider" "3.0.4")
 |#
 
@@ -21 +21 @@
 
 (defun find-mvn () 
+  "Attempt to find a suitable Maven ('mvn') executable on the hosting operating system."
   (dolist (mvn-path *mavens*)
     (let ((mvn 
@@ -76 +77 @@
 
 (defun init ()
+  "Run the initialization strategy to bootstrap a Maven dependency node."
   (unless *mvn-libs-directory*
     (setf *mvn-libs-directory* (find-mvn-libs)))
   (unless (probe-file *mvn-libs-directory*)
-    (error "You must download maven-3.0.3 from http://maven.apache.org/download.html, then set ABCL-ASDF:*MVN-DIRECTORY* appropiately."))
+    (error "You must download maven-3.0.3 or later from http://maven.apache.org/download.html, then set ABCL-ASDF:*MVN-DIRECTORY* appropiately."))
   (unless (ensure-mvn-version)
     (error "We need maven-3.0.3 or later."))
@@ -86 +88 @@
 
 (defparameter *http-wagon-implementations*
-  `("org.apache.maven.wagon.providers.http.HttpWagon" ;; introduced as default with maven-3.0.3
-    "org.apache.maven.wagon.providers.http.LightweightHttpWagon"))
+  `("org.apache.maven.wagon.providers.http.HttpWagon" ;; introduced as default with maven-3.0.4
+    "org.apache.maven.wagon.providers.http.LightweightHttpWagon")
+  "A list of possible candidate implementations that provide access to http and https resources.
+
+Supposedly configurable with the java.net.protocols (c.f. reference maso2000 in the Manual.")
 
 (defun make-wagon-provider ()
+  "Returns an implementation of the org.sonatype.aether.connector.wagon.WagonProvider contract.
+
+The implementation is specified as Lisp closures.  Currently, it only
+specializes the lookup() method if passed an 'http' role hint."
   (unless *init* (init))
   (java:jinterface-implementation 
@@ -138 +147 @@
 
 (defun resolve-artifact (group-id artifact-id &optional (version "LATEST" versionp))
-  "Dynamically resolve Maven dependencies for item with GROUP-ID and ARTIFACT-ID at VERSION.
+  "Directly resolve Maven dependencies for item with GROUP-ID and ARTIFACT-ID at VERSION, ignoring dependencies.
 
 Declared dependencies are not attempted to be located.

trunk/abcl/contrib/abcl-asdf/packages.lisp

@@ -5 +5 @@
    #:resolve-dependencies
 
+   #:find-mvn
+
+   #:*mvn-directory*
+
+   #:init
+
 ;;; "Internal" API
+
+;;;; Maven 
+   #:*mvn-libs-directory*
+
    #:satisfy
    #:as-classpath
@@ -18 +28 @@
 
 (defpackage #:abcl-asdf-test
-  (:use :cl :abcl-rt)
+  (:use :cl #+nil :abcl-test-lisp) ;;; FIXME
   (:export #:run))