Changeset 13834

Timestamp:

01/30/12 20:13:16 (12 years ago)

Author:

ehuelsmann

Message:

Further reduce footprint and complexity by eliminating
helper functions.

File:

• trunk/abcl/src/org/armedbear/lisp/Closure.java (modified) (8 diffs)

trunk/abcl/src/org/armedbear/lisp/Closure.java

@@ -172 +172 @@
   public LispObject execute()
   {
-    if (arity == 0)
-      {
-        return progn(executionBody, environment, 
-                     LispThread.currentThread());
-      }
-    else
       return execute(new LispObject[0]);
   }
     
-  private final LispObject bindParametersAndExecute(LispObject... objects)
-
-  {
-    final LispThread thread = LispThread.currentThread();
-    final SpecialBindingsMark mark = thread.markSpecialBindings();
-
-    Environment ext = new Environment(environment);
-    LispObject[] args = arglist.match(objects, environment, ext, thread);
-    arglist.bindVars(args, ext, thread);
-    declareFreeSpecials(ext);
-    try
-      {
-        return progn(executionBody, ext, thread);
-      }
-    finally
-      {
-        thread.resetSpecialBindings(mark);
-      }
-  }
-
-  public final LispObject invokeArrayExecute(LispObject... objects)
-
-  {
-    return execute(objects);
-  }
-
   @Override
   public LispObject execute(LispObject arg)
   {
-    if (minArgs == 1)
-      {
-        return bindParametersAndExecute(arg);
-      }
-    else
-      {
-        return invokeArrayExecute(arg);
-      }
+        return execute(new LispObject[] {arg});
   }
 
   @Override
   public LispObject execute(LispObject first, LispObject second)
-
-  {
-    if (minArgs == 2)
-      {
-        return bindParametersAndExecute(first, second);
-      }
-    else
-      {
-        return invokeArrayExecute(first, second);
-      }
+  {
+        return execute(new LispObject[] {first, second});
   }
 
@@ -237 +190 @@
   public LispObject execute(LispObject first, LispObject second,
                             LispObject third)
-
-  {
-    if (minArgs == 3)
-      {
-        return bindParametersAndExecute(first, second, third);
-      }
-    else
-      {
-        return invokeArrayExecute(first, second, third);
-      }
+  {
+        return execute(new LispObject[] {first, second, third});
   }
 
@@ -252 +197 @@
   public LispObject execute(LispObject first, LispObject second,
                             LispObject third, LispObject fourth)
-
-  {
-    if (minArgs == 4)
-      {
-        return bindParametersAndExecute(first, second, third, fourth);
-      }
-    else
-      {
-        return invokeArrayExecute(first, second, third, fourth);
-      }
+  {
+        return execute(new LispObject[] {first, second, third, fourth});
   }
 
@@ -268 +205 @@
                             LispObject third, LispObject fourth,
                             LispObject fifth)
-
-  {
-    if (minArgs == 5)
-      {
-        return bindParametersAndExecute(first, second, third, fourth,
-                                        fifth);
-      }
-    else
-      {
-        return invokeArrayExecute(first, second, third, fourth, fifth);
-      }
+  {
+        return execute(new LispObject[] {first, second, third, fourth, fifth});
   }
 
@@ -285 +213 @@
                             LispObject third, LispObject fourth,
                             LispObject fifth, LispObject sixth)
-
-  {
-    if (minArgs == 6)
-      {
-        return bindParametersAndExecute(first, second, third, fourth,
-                                        fifth, sixth);
-      }
-    else
-      {
-        return invokeArrayExecute(first, second, third, fourth, fifth,
-                                  sixth);
-      }
+  {
+        return execute(new LispObject[] {first, second, third, fourth, fifth,
+                                  sixth});
   }
 
@@ -304 +223 @@
                             LispObject fifth, LispObject sixth,
                             LispObject seventh)
-
-  {
-    if (minArgs == 7)
-      {
-        return bindParametersAndExecute(first, second, third, fourth,
-                               fifth, sixth, seventh);
-      }
-    else
-      {
-        return invokeArrayExecute(first, second, third, fourth, fifth,
-                                  sixth, seventh);
-      }
+  {
+        return execute(new LispObject[] {first, second, third, fourth, fifth,
+                                  sixth, seventh});
   }
 
@@ -323 +233 @@
                             LispObject fifth, LispObject sixth,
                             LispObject seventh, LispObject eighth)
-
-  {
-    if (minArgs == 8)
-      {
-        return bindParametersAndExecute(first, second, third, fourth,
-                               fifth, sixth, seventh, eighth);
-      }
-    else
-      {
-        return invokeArrayExecute(first, second, third, fourth, fifth,
-                                  sixth, seventh, eighth);
-      }
-  }
-
-  private void declareFreeSpecials(Environment ext)
-  {
-      for (Symbol special : freeSpecials)
-        ext.declareSpecial(special);
+  {
+        return execute(new LispObject[] {first, second, third, fourth, fifth,
+                                  sixth, seventh, eighth});
   }
 
@@ -351 +246 @@
     args = arglist.match(args, environment, ext, thread);
     arglist.bindVars(args, ext, thread);
-    declareFreeSpecials(ext);
+    for (Symbol special : freeSpecials)
+      ext.declareSpecial(special);
     try
       {