Changeset 13912

Timestamp:

04/15/12 16:24:45 (10 years ago)

Author:

Mark Evenson

Message:

compiler: refuse to load zero-length JVM fasls; added diagnostics.

Additionally, if for the ANSI compiler proclamations the condition (>
*DEBUG* *SAFETY*) is true, actually load the compiled fasl in the
executing JVM. This is a potentially slow operation, but it certainly
makes further execution safer.

If the ANSI proclamination *DEBUG* is non-zero, set the appropiate
plists of symbols containing values of the associatioed compiled
representation.

File:

• trunk/abcl/src/org/armedbear/lisp/compile-file.lisp (modified) (3 diffs)

trunk/abcl/src/org/armedbear/lisp/compile-file.lisp

@@ -86 +86 @@
 (declaim (ftype (function (t) t) verify-load))
 (defun verify-load (classfile)
-  #|(if (> *safety* 0) 
       (and classfile
-         (let ((*load-truename* *output-file-pathname*))
-           (report-error
-            (load-compiled-function classfile))))
-    t)|#
-  (declare (ignore classfile))
-  t)
+           (unless
+                 (> (file-length (open classfile :direction :input))
+                    0)
+             ;;; TODO hook into a real ABCL compiler condition hierarchy
+             (signal "Internal compiler error detected: Fasl contains ~
+zero-length jvm classfile corresponding to ~A." classfile)))
+           (if (> *safety* *speed*)
+               (progn
+                 (warn "Because(> *safety* *speed*): Testing fasl via ~
+the potentially slow loading of its JVM bytecode." )
+                 (let ((*load-truename* *output-file-pathname*))
+                   (report-error
+                    (load-compiled-function classfile))))
+               t))
 
 (declaim (ftype (function (t) t) note-toplevel-form))
@@ -151 +158 @@
     (return-from convert-toplevel-form
       (precompiler:precompile-form form nil *compile-file-environment*)))
-  (let* ((expr `(lambda () ,form))
+  (let* ((toplevel-form (third form))
+         (expr `(lambda () ,form))
          (saved-class-number *class-number*)
          (classfile (next-classfile-name))
@@ -162 +170 @@
             (report-error (jvm:compile-defun nil
                                              expr *compile-file-environment*
-                                             classfile f declare-inline))))
-         (compiled-function (verify-load classfile)))
+                                             classfile f
+                                             declare-inline))))
+         (compiled-function (handler-case (verify-load classfile)
+                              (t (c) 
+                                (error "Compilation failed for JVM class number ~A
+corresponding to form ~A~&with condition ~A" 
+                                       saved-class-number toplevel-form c)))))
     (declare (ignore result))
-    (setf form
-          (if compiled-function
-              `(funcall (sys::get-fasl-function *fasl-loader*
-                                                ,saved-class-number))
-              (precompiler:precompile-form form nil
-                                           *compile-file-environment*)))))
-
-
+    (progn
+      (when (> *debug* 0)
+        ;;; ??? define an API by perhaps exporting these symbols?
+        (setf (getf form 'form-source) 
+              toplevel-form
+              
+              (getf form 'classfile) 
+              classfile
+                   
+              (getf form 'compiled-function) 
+              compiled-function
+                  
+              (getf form 'class-number) 
+              saved-class-number))
+      (setf form
+            (if compiled-function
+                `(funcall (sys::get-fasl-function *fasl-loader*
+                                                  ,saved-class-number))
+                (precompiler:precompile-form form nil
+                                             *compile-file-environment*))))))