Changeset 14117

Timestamp:

08/18/12 10:49:15 (9 years ago)

Author:

ehuelsmann

Message:

3 changes:

• Improve speed of "multi-homed symbol" removal
• Generate autoloader EXPORT commands based on

EXPORTed symbols in the compiled files, instead of
on the symbols currently exported (this one fixes the SLIME

MAKE-THREAD-LOCK issue)

• Reverse the "multi-homed filtering" and the "autoloads file exclusion"

in order to stop considering symbols overridden by extensible
sequences (e.g. COUNT-IF, REMOVE, etc) as being multi-homed:
we want to autoload the non-extensible versions by default.

File:

• trunk/abcl/src/org/armedbear/lisp/compile-system.lisp (modified) (4 diffs)

trunk/abcl/src/org/armedbear/lisp/compile-system.lisp

@@ -91 +91 @@
 
 (defun remove-multi-combo-symbols (combos)
-  (remove-if (lambda (x)
-               (< 1 (count x combos :key #'second)))
-             combos
-             :key #'second))
+  (princ "; Removing multi-homed symbols")
+  (let ((sym-hash (make-hash-table :size (* 2 (length combos)))))
+    (dolist (combo combos)
+      (incf (gethash (second combo) sym-hash 0)))
+    (print (remove-if-not (lambda (x)
+                            (< 1 (gethash x sym-hash)))
+                          combos
+                          :key #'second))
+    (remove-if (lambda (x)
+                 (< 1 (gethash x sym-hash)))
+               combos
+               :key #'second)))
 
 (defun set-equal (set1 set2 &key test)
@@ -119 +127 @@
       (pushnew (first symbol-fileset)
                (cdr (assoc (cdr symbol-fileset) fileset-symbols
-                           :test (lambda (x y) (set-equal x y :test #'string=))))))
+                           :test (lambda (x y)
+                                   (set-equal x y :test #'string=))))))
     fileset-symbols))
 
@@ -164 +173 @@
 (defun generate-autoloads (symbol-files-pathspec)
   (flet ((filter-combos (combos)
-           (remove-if (lambda (x)
-                        ;; exclude the symbols from the files
-                        ;; below: putting autoloaders on some of
-                        ;; the symbols conflicts with the bootstrapping
-                        ;; Primitives which have been defined Java-side
-                        (member x '( ;; function definitions to be excluded
-                                    "fdefinition" "early-defuns"
-                                    "require" "signal"
-                                    "extensible-sequences-base" "restart"
-                                    "extensible-sequences"
-                                    ;; macro definitions to be excluded
-                                    "macros" "backquote" "precompiler")
-                                :test #'string=))
-                      (remove-multi-combo-symbols combos)
-                      :key #'first))
+           (remove-multi-combo-symbols
+            (remove-if (lambda (x)
+                         ;; exclude the symbols from the files
+                         ;; below: putting autoloaders on some of
+                         ;; the symbols conflicts with the bootstrapping
+                         ;; Primitives which have been defined Java-side
+                         (member x '( ;; function definitions to be excluded
+                                     "fdefinition" "early-defuns"
+                                     "require" "signal" "restart"
+
+                                     ;; extensible sequences override
+                                     ;; lots of default functions;
+                                     ;; java-collections implements
+                                     ;; extensible sequences
+                                     "extensible-sequences-base"
+                                     "extensible-sequences" "java-collections"
+
+                                     ;; macro definitions to be excluded
+                                     "macros" ;; "backquote"
+                                     "precompiler")
+                                 :test #'string=))
+                       combos
+                       :key #'first)))
          (symbols-pathspec (filespec)
            (merge-pathnames filespec symbol-files-pathspec)))
     (let ((funcs (filter-combos (load-combos (symbols-pathspec "*.funcs"))))
-          (macs (filter-combos (load-combos (symbols-pathspec "*.macs")))))
+          (macs (filter-combos (load-combos (symbols-pathspec "*.macs"))))
+          (exps (filter-combos (load-combos (symbols-pathspec "*.exps")))))
       (with-open-file (f (symbols-pathspec "autoloads-gen.lisp")
                          :direction :output :if-does-not-exist :create
@@ -199 +217 @@
           ;;    vital to the correct operation of the base system.
 
-          (let ((*package* (find-package package))
-                externals)
-            (do-external-symbols (sym package
-                                      externals)
-              (when (eq (symbol-package sym)
-                        *package*)
-                (push sym externals)))
+          (let* ((*package* (find-package package))
+                 (all-exported-symbols
+                  (remove-duplicates (mapcar #'second exps)))
+                 (externals (remove-if-not (lambda (sym)
+                                             (eq (symbol-package sym)
+                                                 *package*))
+                                           all-exported-symbols)))
             (when externals
               (write-line ";; EXPORTS" f)