Changeset 14168

Timestamp:

10/08/12 18:06:53 (8 years ago)

Author:

Mark Evenson

Message:

Fix ENSURE-REMOTE-REPOSITORY method declaration.

Use the MavenServiceLocator? as opposed to DefaultServiceLocator? which
seems to help out quite a bit.

Add :FORCE keyword options to assist debugging problems.

File:

• trunk/abcl/contrib/abcl-asdf/maven-embedder.lisp (modified) (8 diffs)

trunk/abcl/contrib/abcl-asdf/maven-embedder.lisp

@@ -6 +6 @@
 # Implementation 
 
-Not multi-threaded safe, and unclear how much work that would be.
+Not necessarily multi-threaded safe, and unclear how much work that
+would be, as it is unknown how the Maven implementation behaves.
 
 ## Installing Maven
@@ -23 +24 @@
 |#
 
-;;; N.b. evaluated *after* we load the ABCL specific modifications of ASDF in abcl-asdf.lisp
+;;; N.b. evaluated *after* we load the ABCL specific modifications of
+;;;      ASDF in abcl-asdf.lisp
 
 (in-package :abcl-asdf)
@@ -158 +160 @@
   "A list of possible candidate implementations that provide access to http and https resources.
 
-Supposedly configurable with the java.net.protocols (c.f. reference maso2000 in the Manual.")
+Supposedly configurable with the java.net.protocols (c.f. reference maso2000 in the Manual.)")
 
 (defun make-wagon-provider ()
@@ -185 +187 @@
   (unless *init* (init))
   (let ((locator 
-         (java:jnew "org.apache.maven.repository.internal.DefaultServiceLocator"))
+         (java:jnew "org.apache.maven.repository.internal.MavenServiceLocator"))
+        (wagon-provider-class 
+         (java:jclass "org.sonatype.aether.connector.wagon.WagonProvider"))
+        (wagon-repository-connector-factory-class
+         (java:jclass "org.sonatype.aether.connector.wagon.WagonRepositoryConnectorFactory"))
         (repository-connector-factory-class 
          (java:jclass "org.sonatype.aether.spi.connector.RepositoryConnectorFactory"))
-        (wagon-repository-connector-factory-class
-         (java:jclass "org.sonatype.aether.connector.wagon.WagonRepositoryConnectorFactory"))
-        (wagon-provider-class 
-         (java:jclass "org.sonatype.aether.connector.wagon.WagonProvider"))
         (repository-system-class
          (java:jclass "org.sonatype.aether.RepositorySystem")))
-    (#"addService" locator
-                   repository-connector-factory-class 
-                   wagon-repository-connector-factory-class)
     (#"setServices" locator
                     wagon-provider-class
-                    (java:jnew-array-from-list 
-                     "org.sonatype.aether.connector.wagon.WagonProvider"
-                     (list 
-                      (make-wagon-provider))))
-    (#"getService" locator
-                   repository-system-class)))
+                   (java:jarray-from-list
+                    (list (make-wagon-provider))))
+    (#"addService" locator
+                   repository-connector-factory-class
+                   wagon-repository-connector-factory-class)
+    (values (#"getService" locator
+                           repository-system-class)
+            locator)))
         
 (defun make-session (repository-system)
@@ -216 +217 @@
     (#"setLocalRepositoryManager" 
      session
-     (#"newLocalRepositoryManager" repository-system local-repository))))
+     (#"newLocalRepositoryManager" repository-system
+                                   local-repository))))
 
 (defparameter *maven-http-proxy* nil
@@ -241 +243 @@
 (defparameter *repository-system*  nil
   "The org.sonatype.aether.RepositorySystem used by the Maeven Aether connector.")
-(defun ensure-repository-system ()
-  (unless *repository-system*
+(defun ensure-repository-system (&key (force nil))
+  (when (or force (not *repository-system*))
     (setf *repository-system* (make-repository-system)))
   *repository-system*)
@@ -248 +250 @@
 (defparameter *session* nil
   "Reference to the Maven RepositorySystemSession")
-(defun ensure-session ()
+(defun ensure-session (&key (force nil))
   "Ensure that the RepositorySystemSession has been created.
 
 If *MAVEN-HTTP-PROXY* is non-nil, parse its value as the http proxy."
-  (unless *session*
-    (ensure-repository-system)
+  (when (or force (not *session*))
+    (ensure-repository-system :force force)
     (setf *session* (make-session *repository-system*))
     (#"setRepositoryListener" *session* (make-repository-listener))
@@ -298 +300 @@
 (defparameter *maven-remote-repository*  nil
     "The remote repository used by the Maven Aether embedder.")
-(defun ensure-remote-repository (&key repository *default-repository* repository-p) 
+(defun ensure-remote-repository (&key 
+                                   (force nil)
+                                   (repository *default-repository* repository-p))
   (unless *init* (init))
-  (unless (or repository-p 
-              *maven-remote-repository*)
+  (when (or force  
+            repository-p 
+            (not *maven-remote-repository*))
     (let ((r (make-remote-repository "central" "default" repository)))
       (when *maven-http-proxy*