Changeset 14239

Timestamp:

11/09/12 17:28:12 (10 years ago)

Author:

Mark Evenson

Message:

Fixes #229 so that JCALL works with static member classes.

Added non-working test to putative JSS test suite.

Location:

trunk/abcl

Files:

• contrib/jss/jss.asd (modified) (1 diff)
• contrib/jss/tests.lisp (modified) (1 diff)
• src/org/armedbear/lisp/Java.java (modified) (2 diffs)

trunk/abcl/contrib/jss/jss.asd

@@ -2 +2 @@
 (asdf:defsystem :jss
   :author "Alan Ruttenberg, Mark Evenson"
-  :version "3.0.4" 
-  :components 
-  ((:module base 
-            :pathname "" :serial t 
-            :components ((:file "packages")
-                         (:file "invoke")
-                         (:file "classpath")
-                         (:file "compat")))))
+  :version "3.0.5" 
+  :components ((:module base 
+                        :pathname "" :serial t 
+                        :components ((:file "packages")
+                                     (:file "invoke")
+                                     (:file "classpath")
+                                     (:file "compat")))))
+
+#+nil FIXME
+(asdf:defsystem :jss-tests
+  :depends-on (jss abcl abcl-test-lisp)
+  :components ((:module tests
+                        :pathname "" 
+                        :components ((:file "tests")))))
 
 

trunk/abcl/contrib/jss/tests.lisp

@@ -13 +13 @@
   "234")
 
+;;; http://trac.common-lisp.net/armedbear/ticket/229
+(deftest jss.jcall.1
+    (let* ((headers (#"getHeaderFields" 
+                    (#"openConnection" 
+                     (jss::new 'java.net.url "http://google.com"))))
 
+           (second-header (#"get" *headers*
+                                  (second (jss::set-to-list (#"keySet"
+                                  *headers*))))))
+      (#"size" *ural*))
+-1)
+
+

trunk/abcl/src/org/armedbear/lisp/Java.java

@@ -889 +889 @@
                     methodArgs[i-2] = arg.javaInstance(argTypes[i-2]);
             }
+            if (!method.isAccessible()) {
+                 // Possible for static member classes: see #229
+                 if (Modifier.isPublic(method.getModifiers())) { 
+                    method.setAccessible(true);
+                 }
+      }
             return JavaObject.getInstance(method.invoke(instance, methodArgs),
                                           translate,
@@ -962 +968 @@
         if(method == null) {
             actualClass = instance.getClass();
-            if(intendedClass != actualClass &&
-               Modifier.isPublic(actualClass.getModifiers())) {
+            if(intendedClass != actualClass) { 
                 method = findMethod(actualClass, methodName, methodArgs);
+    if (method != null) {
+       if (isMethodCallableOnInstance(actualClass, method)) {
+          return method;
+       }
+    }
             }
         }
         return method;
+    }
+    
+    private static boolean isMethodCallableOnInstance(Class instance, Method method) {
+       if (Modifier.isPublic(method.getModifiers())) {
+    return true;
+       }
+       if (instance.isMemberClass()) {
+    return isMethodCallableOnInstance(instance.getEnclosingClass(), method);
+       }
+       return false;
     }