Changeset 14373

Timestamp:

02/13/13 19:29:31 (11 years ago)

Author:

Mark Evenson

Message:

Backport r14364 | mevenson | 2013-01-31 11:02:29 +0100 (Thu, 31 Jan 2013) | 9 lines

ASDF systems using the MVN component now load again.

log4j.asd example corrected as well.

FIND-MVN now emits a warning if it cannot actually find a Maven exectuable.

Thanks to Milos Negovanovic for identifying the problem with a patch.

Fixes #299.

Location:

branches/1.1.x/contrib/abcl-asdf

Files:

• abcl-asdf.lisp (modified) (1 diff)
• maven-embedder.lisp (modified) (2 diffs)
• tests/example.lisp (modified) (1 diff)
• tests/log4j.asd (modified) (2 diffs)

branches/1.1.x/contrib/abcl-asdf/abcl-asdf.lisp

@@ -132 +132 @@
           (unless (java:jinstance-of-p (java:java-exception-cause e)
                                   "java.lang.ClassNotFoundException")
-            (error "Unexpected Java exception~&~A.~&" e))
-          (if (find-mvn)
-              (resolve-dependencies group-id artifact-id version)
-              (if alternate-uri
-                  (values (namestring alternate-uri) alternate-uri)
-                  (t 
-                   (error "Failed to resolve MVN component name ~A." name)))))))))
+            (error "Unexpected Java exception~&~A.~&" e))))
+      (if (find-mvn)
+          (resolve-dependencies group-id artifact-id version)
+          (if alternate-uri
+              (values (namestring alternate-uri) alternate-uri)
+              (t 
+               (error "Failed to resolve MVN component name ~A." name)))))))
   
 (defun as-classpath (classpath)

branches/1.1.x/contrib/abcl-asdf/maven-embedder.lisp

@@ -51 +51 @@
   "Attempt to find a suitable Maven ('mvn') executable on the hosting operating system.
 
-Returns the path of the Maven executable or nil if none are found."
+Returns the path of the Maven executable or nil if none are found.
+
+Emits warnings if not able to find a suitable executable."
 
   (let ((m2-home (ext:getenv "M2_HOME"))
@@ -98 +100 @@
                              mvn-path e)))))
             (when mvn
-              (return-from find-mvn mvn))))))))
+              (return-from find-mvn mvn)))))))
+  (warn "Unable to locate Maven executable."))
 
 (defun find-mvn-libs ()

branches/1.1.x/contrib/abcl-asdf/tests/example.lisp

@@ -1 @@
-(in-package :abcl-asdf-test)
+(in-package :cl-user)
 
-;;;(deftest LOG4J.2
-;;;    (progn
 (defun test-LOG4J.2 ()
-  (asdf:load-system "log4j")
-  (let ((logger (#"getLogger" 'log4j.Logger (symbol-name (gensym)))))
-    (#"trace" logger "Kilroy wuz here.")))
-;;;  t)
+  "Output a message to the Console. 
+
+Note:  for users of SLIME, this will appear in the associated *inferior-lisp* buffer."
+  (#"configure" 'log4j.BasicConfigurator)
+  (#"info" (#"getRootLogger" 'log4j.Logger) "Kilroy wuz here."))
 
 
 
 
+
+
+

branches/1.1.x/contrib/abcl-asdf/tests/log4j.asd

@@ -1 +1 @@
 ;;;; -*- Mode: LISP -*-
-(in-package :asdf)
 
-(defsystem :log4j
-  :components 
-  ((:module log4j.jar :components 
+(asdf:defsystem :log4j  
+  :defsystem-depends-on (abcl-asdf)
+  :components ((:module log4j.jar :components 
             ((:mvn "log4j/log4j/1.2.15")))
    (:module source :pathname "" :components
@@ -10 +9 @@
             :depends-on (log4j.jar))))
 
-  
+(defmethod perform ((o asdf:test-op) (s (eql (asdf:find-system :log4j))))
+  (asdf:load-system :log4j)
+  (eval (read-from-string "(cl-user::test-log4j.2)")))