Changeset 15502 for trunk/abcl/build.xml

Timestamp:

05/10/21 13:10:29 (23 months ago)

Author:

Mark Evenson

Message:

build: deprecate use of abcl.implementation.version

Use abcl.version instead, fixing manifests for jar packaging.

The usage of abcl.implementation.version is now deprecated as not
working for a long time. The intention was that if a
given source tree could be unidentified as being under source control
by the presence of given revision control system artifacts, the
abcl.implementation.version would contain a version derived from the
revision control system.

To hack around the non-prescriptive nature of Ant, chains of
conditional targets had to be created that while might have once
worked for Subversion, were going to get increasingly hairy for
Mercurial and Git.

File:

• trunk/abcl/build.xml (modified) (6 diffs)

trunk/abcl/build.xml

@@ -431 +431 @@
     </target>
 
+    <!-- 
+The usage of abcl.implementation.version is deprecated as not working.
+The intention of this value was that if a given source tree could be
+unidentified as being under source control by the presence of given
+revision control system artifacts, the abcl.implementation.version
+would contain a version derived from the revision control system.
+
+To hack around the non-prescriptive nature of Ant, chains of
+conditional targets had to be created that while might have once
+worked for Subversion, were going to get increasingly hairy for
+Mercurial and Git.
+    -->
+
     <target name="abcl.stamp.version" 
             depends="abcl.version.src,abcl.stamp.version.1,abcl.stamp.version.2"
@@ -511 +524 @@
                        value="ABCL"/>
             <attribute name="Implementation-Version"  
-                       value="${abcl.implementation.version}"/>
+                       value="${abcl.version}"/>
             <attribute name="Implementation-Build" 
                        value="${build}"/>
@@ -521 +534 @@
     </target>
 
-    <target name="abcl-aio.jar" depends="abcl.compile,abcl.stamp">
+    <target name="abcl-aio.jar"
+            depends="abcl.jar.uptodate">
       <mkdir dir="${dist.dir}"/>
       <jar destfile="${abcl-aio.jar.path}"
@@ -544 +558 @@
                        value="ABCL"/>
             <attribute name="Implementation-Version"  
-                       value="${abcl.implementation.version}"/>
+                       value="${abcl.version}"/>
             <attribute name="Implementation-Build" 
                        value="${build}"/>
@@ -553 +567 @@
             <!-- FIXME: declare separate abcl-contrib version? -->
             <attribute name="Implementation-Version"  
-                       value="${abcl.implementation.version}"/>
+                       value="${abcl.version}"/>
           </section>
           <section name="tools">
@@ -563 +577 @@
                        value="org.abcl-source"/>
             <attribute name="Implementation-Version"  
-                       value="${abcl.implementation.version}"/>
+                       value="${abcl.version}"/>
           </section>
         </manifest>