Opened 8 years ago

Closed 8 years ago

#261 closed defect (fixed)

Loading Systems from abcl-contrib.jar fails

Reported by: Christoph Egger Owned by: Mark Evenson
Priority: major Milestone:
Component: abcl-contrib Version:
Keywords: Cc: siccegge@…
Parent Tickets:

Description

% abcl
Armed Bear Common Lisp 1.1.0-dev-svn-14226
Java 1.6.0_18 Sun Microsystems Inc.
OpenJDK Client VM
Low-level initialization completed in 0.42 seconds.
Startup completed in 2.184 seconds.
Type ":help" for a list of available commands.
CL-USER(1): (require :abcl-contrib)
("ASDF" "ABCL-CONTRIB")
CL-USER(2): (require :asdf-jar)
#<THREAD "interpreter" {1685BE9}>: Debugger invoked on condition of type SIMPLE-ERROR
  Don't know how to REQUIRE ASDF-JAR.
Restarts:
  0: TOP-LEVEL Return to top level.
[1] CL-USER(3): 

Change History (5)

comment:1 Changed 8 years ago by Christoph Egger

Component: (A)MOPabcl-contrib
Owner: changed from ehuelsmann to Mark Evenson

comment:2 Changed 8 years ago by Christoph Egger

Ah I see. it expects to see some details on the filename of the abcl main jar which turns out to not be true here so fails to detect the path for the main .jar and sequently the -contrib .jar

CL-USER(6): (java:dump-classpath)
((#<org.armedbear.lisp.JavaClassLoader org.armedbear.lisp.JavaClassLoad.... {60D861B7}>) (#<sun.misc.Launcher$AppClassLoader sun.misc.Launcher$AppClassLoader.... {40E2A37B}> #P"/usr/share/java/abcl-1.1.0~svn14231.jar" #P"/usr/share/java/abcl-contrib-1.1.0~svn14231.jar" #P"/home/christoph") (#<sun.misc.Launcher$ExtClassLoader sun.misc.Launcher$ExtClassLoader.... {56920EE7}> #P"/usr/lib/jvm/java-6-openjdk-common/jre/lib/ext/dnsns.jar" #P"/usr/lib/jvm/java-6-openjdk-common/jre/lib/ext/localedata.jar" #P"/usr/lib/jvm/java-6-openjdk-common/jre/lib/ext/pulse-java.jar" #P"/usr/lib/x86_64-linux-gnu/jni/libatk-wrapper.so.0.0.18" #P"/usr/lib/jvm/java-6-openjdk-common/jre/lib/ext/sunjce_provider.jar" #P"/usr/share/java/java-atk-wrapper.jar" #P"/usr/lib/jvm/java-6-openjdk-common/jre/lib/ext/sunpkcs11.jar"))

comment:3 Changed 8 years ago by Christoph Egger

And again so one can actually read it

((#<sun.misc.Launcher$AppClassLoader sun.misc.Launcher$AppClassLoader.... {50F8AE79}>
  #P"/usr/share/java/abcl-1.1.0~svn14231.jar"
  #P"/usr/share/java/abcl-contrib-1.1.0~svn14231.jar"
  #P"/home/christoph")
 (#<sun.misc.Launcher$ExtClassLoader sun.misc.Launcher$ExtClassLoader.... {145D424}>
  #P"/usr/lib/jvm/java-6-openjdk-common/jre/lib/ext/dnsns.jar"
  #P"/usr/lib/jvm/java-6-openjdk-common/jre/lib/ext/localedata.jar"
  #P"/usr/lib/jvm/java-6-openjdk-common/jre/lib/ext/pulse-java.jar"
  #P"/usr/lib/x86_64-linux-gnu/jni/libatk-wrapper.so.0.0.18"
  #P"/usr/lib/jvm/java-6-openjdk-common/jre/lib/ext/sunjce_provider.jar"
  #P"/usr/share/java/java-atk-wrapper.jar"
  #P"/usr/lib/jvm/java-6-openjdk-common/jre/lib/ext/sunpkcs11.jar"))

comment:4 Changed 8 years ago by Christoph Egger

OK this is how I fixed it for me.

Complies with best-practice for versioning of pre-release software in Debian combined with policy on how to name the .jar files

Index: src/org/armedbear/lisp/abcl-contrib.lisp
===================================================================
--- src/org/armedbear/lisp/abcl-contrib.lisp	(revision 14231)
+++ src/org/armedbear/lisp/abcl-contrib.lisp	(working copy)
@@ -10,7 +10,7 @@
                 (equal (pathname-type p) "jar")
                 (java:jstatic "matches"
                               "java.util.regex.Pattern" 
-                              "abcl(-[0-9]\\.[0-9]\\.[0-9](-.+)?)?" 
+                              "abcl(-[0-9]\\.[0-9]\\.[0-9]([+~-].+)?)?" 
                               (pathname-name p))
                 p)))
     (dolist (loader (java:dump-classpath))

comment:5 Changed 8 years ago by Mark Evenson

Resolution: fixed
Status: newclosed

(In [14232]) Fixes #261: ABCL-CONTRIB finding logic widened to Debian packaging conventions.

Thanks for Christoph.

Note: See TracTickets for help on using tickets.