Opened 12 years ago

Closed 10 years ago

#66 closed task (fixed)

Tests for DEFINE-METHOD-COMBINATION (long form)

Reported by: ehuelsmann Owned by: unassigned
Priority: critical Milestone: 1.0
Component: CLOS Version: 1.0
Keywords: Cc:
Parent Tickets:

Description (last modified by ehuelsmann)

The issue used to be lack of support for D-M-C, now, it's about porting SBCL's tests (and required fixes) to ABCL; SBCL doesn't use RT - that's the main issue.

Attachments (2)

run-d-m-c-20100802a.patch (20.8 KB) - added by Mark Evenson 11 years ago.
Integration of SACLA/XCL DEFINE-METHOD-COMBINATION
run-d-m-c-20100811a.diff (21.5 KB) - added by Mark Evenson 11 years ago.
long form of DEFINE-METHOD-COMBINATION snapshot

Download all attachments as: .zip

Change History (17)

comment:1 Changed 11 years ago by Mark Evenson

Milestone: 0.19
Owner: changed from somebody to Mark Evenson
Status: newassigned

XCL which has extended and modified ABCL's CLOS has implemented the long form of DEFINE-METHOD-COMBINATION in XCL-0.0.0.290.

Backporting shouldn't be that much of a problem (once I understand what is going on).

comment:2 Changed 11 years ago by ehuelsmann

Another suggestion - by Tobias Rittweiler - is to copy the code from SACLA:

"
SACLA seems to contain an implementation of the long form of D-M-C:

http://homepage1.nifty.com/bmonkey/lisp/sacla/html/lisp/clos.lisp.html

It's released under a BSD license, so just copying it into ABCL is
viable, but the code may also just be used for inspiration.
"

comment:3 Changed 11 years ago by ehuelsmann

Milestone: 0.190.20

comment:4 Changed 11 years ago by Mark Evenson

Priority: majorblocker

From my analysis of both codebases it seems like XCL did indeed copy the code from SACLA, so this is the preferred integration strategy.

comment:5 Changed 11 years ago by Mark Evenson

Owner: changed from Mark Evenson to unassigned

I am not actively working on this, so marking this as available in case someone else wants to charge ahead.

comment:6 Changed 11 years ago by Mark Evenson

Milestone: 0.200.21
Version: 1.0

Changed 11 years ago by Mark Evenson

Attachment: run-d-m-c-20100802a.patch added

Integration of SACLA/XCL DEFINE-METHOD-COMBINATION

comment:7 Changed 11 years ago by Mark Evenson

Milestone: 0.210.22

A checkpoint of work that may be of interest to those who have more time than I currently do.

The attached patch takes a stab at integrating the work in Sacla/XCL into ABCL but does not work.

Arguments for long D-M-C seem to be correct and a new structure is in place, but calling this does not work as we now need an implementation of CALL-METHOD which should be a locally defined macro in the context of the method call.

Further analysis and help on how this would work is welcome

comment:8 Changed 11 years ago by Mark Evenson

A further checkpoint that actually passes the long form of method combination in the ANSI test suite which is still a bit unbelievable.

Changed 11 years ago by Mark Evenson

Attachment: run-d-m-c-20100811a.diff added

long form of DEFINE-METHOD-COMBINATION snapshot

comment:9 Changed 11 years ago by ehuelsmann

Milestone: 0.220.23

With Mark's pre-work, this should be doable in the next month.

comment:10 Changed 11 years ago by ehuelsmann

Priority: blockercritical
Type: defecttask

Current status:

Mark's patch is in trunk.

We need tests... Adjusting subject line accordingly
(from: Support for DEFINE-METHOD-COMBINATION (long form))

comment:11 Changed 11 years ago by ehuelsmann

Description: modified (diff)
Summary: Support for DEFINE-METHOD-COMBINATION (long form)Tests for DEFINE-METHOD-COMBINATION (long form)

comment:12 Changed 11 years ago by Mark Evenson

As for being more descriptive about the non-functional parts of my patch, I think CALL-NEXT-METHOD does not currently do anything useful somehow failing to be expanded to the macro definition.

comment:13 Changed 10 years ago by Mark Evenson

Milestone: 0.23unscheduled

comment:14 Changed 10 years ago by Mark Evenson

Milestone: unscheduled1.0

comment:15 Changed 10 years ago by ehuelsmann

Resolution: fixed
Status: assignedclosed

Fixed with r13593 (and earlier).

Note: See TracTickets for help on using tickets.