Opened 13 years ago

Closed 13 years ago

#7 closed defect (fixed)

SLIME support (delivered with ABCL) needs updating

Reported by: ehuelsmann Owned by: ehuelsmann
Priority: minor Milestone:
Component: other Version:
Keywords: Cc:
Parent Tickets:

Description

The default implementation is WAY outdated. This issue can be closed if the implementation runs verified correctly against what is the HEAD of SLIME when closing the issue.

(Implementing additional features is nice, but not required for this issue.)

Attachments (2)

remove-old-slime.patch (62.2 KB) - added by Mark Evenson 13 years ago.
Remove uneeded slime files
remove-slime-build.patch (1.6 KB) - added by Mark Evenson 13 years ago.
Remove uneeded slime files from build

Download all attachments as: .zip

Change History (12)

comment:1 Changed 13 years ago by Mark Evenson

Owner: changed from somebody to Mark Evenson
Status: newassigned

I'll take the SLIME support issues (since I usually debug them anyways).

SLIME from CVS HEAD works pretty well with ABCL at the moment, but the main part of this ticket is to remove the

slime-loader.lisp	slime.lisp
swank-abcl.lisp		swank-loader.lisp	swank-protocol.lisp	swank-xcl.lisp
swank-allegro.lisp	swank-package.lisp	swank-sbcl.lisp		swank.lisp

files from src/org/armedbear/lisp directory, and verify that everything still works.

comment:2 Changed 13 years ago by Mark Evenson

There are also the files

SlimeInputStream.java
SlimeOutputStream.java

that are also (?) unused.

comment:3 Changed 13 years ago by Mark Evenson

Answering previous comment: no, the functions

  EXTENSIONS:MAKE-SLIME-INPUT-STREAM
  EXTENSIONS:MAKE-SLIME-OUTPUT-STREAM

are definitely used (see swank-abcl.lisp:27 ff.)

As a side note, this is probably a good place to hook the creation of UTF-8 SLIME interaction in support of other input methods.

Changed 13 years ago by Mark Evenson

Attachment: remove-old-slime.patch added

Remove uneeded slime files

comment:4 Changed 13 years ago by Mark Evenson

Owner: changed from Mark Evenson to ehuelsmann
Priority: majorminor

I've been running (and rebuilding) ABCL and SLIME for a week or so without the files

slime-loader.lisp	slime.lisp
swank-abcl.lisp		swank-loader.lisp	swank-protocol.lisp	swank-xcl.lisp
swank-allegro.lisp	swank-package.lisp	swank-sbcl.lisp		swank.lisp

The attached patch removes them from the tree.

Reassigning to Erik to remove from trunk.

comment:5 Changed 13 years ago by ehuelsmann

Removal of the files mentioned above has been completed in commit r11375. It would be interesting to see to what extent ABCL needs to be modified to work with swank-gray.lisp.

As soon as it does, the classes SlimeInputStream? and SlimeOutputStream? can be removed.

comment:6 Changed 13 years ago by ehuelsmann

BTW, swank-gray compiles without warnings on the latest of trunk (r11375).

comment:7 Changed 13 years ago by ehuelsmann

But:

(require 'asdf)
(require 'gray-streams)
(asdf:oos 'asdf:load-op :swank)

breaks the asdf operation.

See ticket #20.

comment:8 Changed 13 years ago by Mark Evenson

The build system for ABCL should be further "tightened" with the 'remove-old-slime.patch', removing the references to the removed files in 'build.xml' as well as 'compile-system.lisp'.

Changed 13 years ago by Mark Evenson

Attachment: remove-slime-build.patch added

Remove uneeded slime files from build

comment:9 in reply to:  7 Changed 13 years ago by Mark Evenson

Replying to ehuelsmann:

But:

(require 'asdf)
(require 'gray-streams)
(asdf:oos 'asdf:load-op :swank)

breaks the asdf operation.

See ticket #20.

The patch [attached to ticket #20][1] allows this operation to succeed.

[1]: http://trac.common-lisp.net/armedbear/attachment/ticket/20/pprint-gray-streams.lisp

comment:10 Changed 13 years ago by ehuelsmann

Resolution: fixed
Status: assignedclosed

All slime artifacts have been removed. remove-slime-build.patch committed in r11376. Closing this issue. (We don't need to deliver Slime with ABCL; Slime CVS changes too often to keep up. Users should download their own.)

Note: See TracTickets for help on using tickets.